Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: Auto-Incrementing Column, C++ client part1 ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/19272/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19272/1//COMMIT_MSG@7 PS1, Line 7: Auto Add the Jira to keep track of the patches. http://gerrit.cloudera.org:8080/#/c/19272/1//COMMIT_MSG@17 PS1, Line 17: doesn't don't http://gerrit.cloudera.org:8080/#/c/19272/1//COMMIT_MSG@25 PS1, Line 25: in delete http://gerrit.cloudera.org:8080/#/c/19272/1/src/kudu/client/schema-internal.h File src/kudu/client/schema-internal.h: http://gerrit.cloudera.org:8080/#/c/19272/1/src/kudu/client/schema-internal.h@89 PS1, Line 89: non_unique_primary_key; > non_unique_primary_key have conflict with primary_key. How about change non +1 http://gerrit.cloudera.org:8080/#/c/19272/1/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/19272/1/src/kudu/client/schema.h@499 PS1, Line 499: uqnique nit: unique http://gerrit.cloudera.org:8080/#/c/19272/1/src/kudu/client/schema.h@582 PS1, Line 582: increment nit: Let's call it auto-incrementing everywhere to keep it uniform. -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 28 Nov 2022 17:30:21 +0000 Gerrit-HasComments: Yes
