Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: Auto-Incrementing Column, C++ client part1 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19272/1/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/19272/1/src/kudu/common/schema.cc@198 PS1, Line 198: const std::string ColumnSchema::auto_incrementing_id = "auto_incrementing_id"; > I guess it makes sense to create a method for that: that's more flexible if This should be property of KuduSchema object. -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 30 Nov 2022 21:19:14 +0000 Gerrit-HasComments: Yes
