Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19281 )
Change subject: WIP KUDU-3406 memory budgeting for CompactRowSetsOp ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19281/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/19281/2/src/kudu/tablet/tablet.cc@2339 PS2, Line 2339: FLAGS_rowset_compaction_memory_estimate_enabled Why not replace with: FLAGS_rowset_compaction_memory_estimate_enabled && !much_of_ancient_data -- To view, visit http://gerrit.cloudera.org:8080/19281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c171284944831e95c45a993d85fbefe89048cf Gerrit-Change-Number: 19281 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 06 Dec 2022 04:31:19 +0000 Gerrit-HasComments: Yes
