Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19281 )
Change subject: WIP KUDU-3406 memory budgeting for CompactRowSetsOp ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19281/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/19281/2/src/kudu/tablet/tablet.cc@2287 PS2, Line 2287: undos_total_size > Do you think it makes sense to have this and ancient_undos_total_size expos That's a good point. I think we should also add more per-table metrics, such as: * the ratio of the actual data read from UNDO deltas to the estimated size * the amount of data read across deltas in all disk delta stores, compressed * the amount of data read across deltas in all disk delta stores, uncompressed and decoded Those should be useful in making more precise estimation of the amount of memory needed for rowset merge compaction. The assumption is that the data pattern stays same during tablet's lifetime. http://gerrit.cloudera.org:8080/#/c/19281/2/src/kudu/tablet/tablet.cc@2339 PS2, Line 2339: FLAGS_rowset_compaction_memory_estimate_enabled > Why not replace with: The code has been changed; it's not relevant anymore. http://gerrit.cloudera.org:8080/#/c/19281/2/src/kudu/tablet/tablet.cc@2344 PS2, Line 2344: undos_total_size > With the ultimate fix, we should bother about total size of the deltas. Si Ah, I meant '... we shouldn't bother about the total size of deltas ...' in the ultimate fix. -- To view, visit http://gerrit.cloudera.org:8080/19281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c171284944831e95c45a993d85fbefe89048cf Gerrit-Change-Number: 19281 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 06 Dec 2022 16:32:13 +0000 Gerrit-HasComments: Yes
