Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19281 )
Change subject: WIP KUDU-3406 memory budgeting for CompactRowSetsOp ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/19281/3/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: http://gerrit.cloudera.org:8080/#/c/19281/3/src/kudu/tablet/diskrowset.cc@99 PS3, Line 99: postone > nit: postpone Done http://gerrit.cloudera.org:8080/#/c/19281/3/src/kudu/tablet/diskrowset.cc@102 PS3, Line 102: euristic > nit: heuristic Done http://gerrit.cloudera.org:8080/#/c/19281/3/src/kudu/tablet/diskrowset.cc@600 PS3, Line 600: const uint64_t undos_total_size = delta_tracker_->UndoDeltaOnDiskSize(); > Move this inside if condition below. Done -- To view, visit http://gerrit.cloudera.org:8080/19281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c171284944831e95c45a993d85fbefe89048cf Gerrit-Change-Number: 19281 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 16 Dec 2022 18:10:31 +0000 Gerrit-HasComments: Yes
