Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18471 )
Change subject: plumb JWT authentication into clients ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/client/client.cc@354 PS7, Line 354: const auto& jwt = pb.jwt(); : messenger->set_jwt(jwt); nit: could this be just messenger->set_jwt(pb.jwt()); ? http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/server/server_base.cc@660 PS7, Line 660: } else { : jwt_verifier = std::make_shared<SimpleJwtVerifier>(); : } Is it possible not to set any JWT verifier in this case at all? -- To view, visit http://gerrit.cloudera.org:8080/18471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfc2640c047a2e3bb5ea03aea4439cea2532e23 Gerrit-Change-Number: 18471 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 13 Dec 2022 17:36:36 +0000 Gerrit-HasComments: Yes
