Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18471 )
Change subject: plumb JWT authentication into clients ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/server/server_base.cc@256 PS7, Line 256: jwks_url Should we indicate jwks_url has higher priority than jwks_file_path if both flags are set? http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/server/server_base.cc@660 PS7, Line 660: } else { : jwt_verifier = std::make_shared<SimpleJwtVerifier>(); : } > Is it possible not to set any JWT verifier in this case at all? Should we write warning message if FLAGS_jwt_token_auth is true and both FLAGS_jwks_url and FLAGS_jwks_file_path are empty string? -- To view, visit http://gerrit.cloudera.org:8080/18471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfc2640c047a2e3bb5ea03aea4439cea2532e23 Gerrit-Change-Number: 18471 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 13 Dec 2022 19:20:15 +0000 Gerrit-HasComments: Yes
