Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18471 )
Change subject: plumb JWT authentication into clients ...................................................................... Patch Set 8: (3 comments) I added two validators, one to check if both jwks_url and jwks_file_path are empty when jwt_auth is enabled, the other to check that only one of them is set. http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/rpc/negotiation.cc@22 PS7, Line 22: > I guess IWYU would be happy to see <ctime> in the group of the C++ includes Done http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/server/server_base.cc@256 PS7, Line 256: jwks_url > +1 I agree with Alexey, that we should only allow one of these to be set. http://gerrit.cloudera.org:8080/#/c/18471/7/src/kudu/server/server_base.cc@660 PS7, Line 660: return s.CloneAndPrepend("FS layout already exists; not overwriting existing layout"); : } : > That's a good idea, indeed. We can run that check as early as possible usi Done -- To view, visit http://gerrit.cloudera.org:8080/18471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfc2640c047a2e3bb5ea03aea4439cea2532e23 Gerrit-Change-Number: 18471 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 14 Dec 2022 11:11:23 +0000 Gerrit-HasComments: Yes
