Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18471 )
Change subject: plumb JWT authentication into clients ...................................................................... Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/18471/9/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18471/9/src/kudu/server/server_base.cc@247 PS9, Line 247: "name from the token payload."); > Please mark all these new flags with the 'experimental' tag. Done http://gerrit.cloudera.org:8080/#/c/18471/9/src/kudu/server/server_base.cc@248 PS9, Line 248: jwt_validate_s > Maybe, rename this into 'enable_jwt_token_authn'? Done http://gerrit.cloudera.org:8080/#/c/18471/9/src/kudu/server/server_base.cc@251 PS9, Line 251: is configuration is se > I guess jwt_validate_signature flag should be tagged 'unsafe'. Done http://gerrit.cloudera.org:8080/#/c/18471/9/src/kudu/server/server_base.cc@253 PS9, Line 253: "for which TLS is handled by proxy."); > I guess jwt_allow_without_tls flag should be tagged 'unsafe'. Done http://gerrit.cloudera.org:8080/#/c/18471/9/src/kudu/server/server_base.cc@360 PS9, Line 360: true > Got it Done http://gerrit.cloudera.org:8080/#/c/18471/9/src/kudu/server/server_base.cc@684 PS9, Line 684: rpc::MessengerBuilder builder(name_); > +1 Done http://gerrit.cloudera.org:8080/#/c/18471/9/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18471/9/src/kudu/util/jwt-util-test.cc@877 PS9, Line 877: > nit: maybe change this to 'kudu'? Done -- To view, visit http://gerrit.cloudera.org:8080/18471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfc2640c047a2e3bb5ea03aea4439cea2532e23 Gerrit-Change-Number: 18471 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 15 Dec 2022 13:54:01 +0000 Gerrit-HasComments: Yes
