Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19097 )
Change subject: KUDU-1945 Auto-Incrementing Column ...................................................................... Patch Set 18: (5 comments) http://gerrit.cloudera.org:8080/#/c/19097/18/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/19097/18/src/kudu/integration-tests/auto_incrementing-itest.cc@108 PS18, Line 108: RETURN_NOT_OK change to return. http://gerrit.cloudera.org:8080/#/c/19097/18/src/kudu/integration-tests/auto_incrementing-itest.cc@124 PS18, Line 124: } return OK after finishing the loop http://gerrit.cloudera.org:8080/#/c/19097/18/src/kudu/integration-tests/auto_incrementing-itest.cc@128 PS18, Line 128: nit: extra space http://gerrit.cloudera.org:8080/#/c/19097/18/src/kudu/integration-tests/auto_incrementing-itest.cc@142 PS18, Line 142: StringifyRowsFromResponse(schema, rpc, &resp, results); missing return value http://gerrit.cloudera.org:8080/#/c/19097/18/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/19097/18/src/kudu/tablet/ops/write_op.cc@195 PS18, Line 195: if (state_->consensus_round()) { : if (is_leader && state_->tablet_replica()->tablet()->schema()->has_auto_incrementing()) { Curious why need two if? Could we just move the position for state_->consensus_round()? -- To view, visit http://gerrit.cloudera.org:8080/19097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dbde9095da78f6d1bd00adcc0a6e7dd63082bbc Gerrit-Change-Number: 19097 Gerrit-PatchSet: 18 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 10 Jan 2023 06:08:57 +0000 Gerrit-HasComments: Yes
