Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19097 )
Change subject: KUDU-1945 Auto-Incrementing Column ...................................................................... Patch Set 20: Code-Review+1 (3 comments) Overall looks good, just a few nits from my side in addition to what Wenzhe pointed at. Also, IWYU isn't yet happy: 15:25:19 >>> Fixing #includes in '/home/jenkins-slave/workspace/kudu-master/1/src/kudu/tablet/tablet.cc' 15:25:19 @@ -51,10 +51,8 @@ 15:25:19 #include "kudu/common/scan_spec.h" 15:25:19 #include "kudu/common/schema.h" 15:25:19 #include "kudu/common/timestamp.h" 15:25:19 -#include "kudu/consensus/consensus.pb.h" 15:25:19 #include "kudu/consensus/log_anchor_registry.h" 15:25:19 #include "kudu/consensus/opid.pb.h" 15:25:19 -#include "kudu/consensus/raft_consensus.h" 15:25:19 #include "kudu/fs/block_manager.h" 15:25:19 #include "kudu/fs/fs_manager.h" 15:25:19 #include "kudu/fs/io_context.h" 15:25:19 IWYU would have edited 1 files on your behalf. http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/client/client-test.cc@9952 PS20, Line 9952: 8 nit: consider introducing a constant for this -- with that, 'upper_bound' would be derived from the number of thread and the 'num_rows' constant below. Also, use the new constant for setting the initial value for 'client_latch'. http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/client/client-test.cc@9994 PS20, Line 9994: + nit: add spaces around '+' sign http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/integration-tests/auto_incrementing-itest.cc@136 PS20, Line 136: } nit: maybe, align the closing parenthesis with the opening one? -- To view, visit http://gerrit.cloudera.org:8080/19097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dbde9095da78f6d1bd00adcc0a6e7dd63082bbc Gerrit-Change-Number: 19097 Gerrit-PatchSet: 20 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 13 Jan 2023 05:37:43 +0000 Gerrit-HasComments: Yes
