Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19097 )
Change subject: KUDU-1945 Auto-Incrementing Column ...................................................................... Patch Set 20: (4 comments) http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/client/client-test.cc@9952 PS20, Line 9952: 8 > nit: consider introducing a constant for this -- with that, 'upper_bound' w Done http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/client/client-test.cc@9994 PS20, Line 9994: + > nit: add spaces around '+' sign Done http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/integration-tests/auto_incrementing-itest.cc@136 PS20, Line 136: } > nit: maybe, align the closing parenthesis with the opening one? Done http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/19097/20/src/kudu/tablet/ops/write_op.cc@196 PS20, Line 196: if (state_->consensus_round() && state_->tablet_replica()->tablet()->schema()-> > nit: break line at '&&' for better readability Done -- To view, visit http://gerrit.cloudera.org:8080/19097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dbde9095da78f6d1bd00adcc0a6e7dd63082bbc Gerrit-Change-Number: 19097 Gerrit-PatchSet: 20 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 13 Jan 2023 06:49:11 +0000 Gerrit-HasComments: Yes
