Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19097 )
Change subject: KUDU-1945 Auto-Incrementing Column ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/19097/19/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/19097/19/src/kudu/integration-tests/auto_incrementing-itest.cc@125 PS19, Line 125: // Returns a scan response from the tablet on the given tablet server. : Status ScanTablet(int ts, const string& tablet_id, vector<string>* results) { : ScanResponsePB resp; : RpcController rpc; : ScanRequestPB req; : : NewScanRequestPB* scan = req.mutable_new_scan_request(); : scan->set_tablet_id(tablet_id); : scan->set_read_mode(READ_LATEST); : : Schema schema = Schema({ ColumnSchema("c0", INT32), : ColumnSchema("c1",INT64, false,false, true), : },2); : RETURN_NOT_OK(SchemaToColumnPBs(schema, scan->mutable_projected_columns())); : RETURN_NOT_OK(cluster_->tserver_proxy(ts)->Scan(req, &resp, &rpc)); : StringifyRowsFromResponse(schema, rpc, &resp, results); : return Status::OK(); : } nit: indent space -- To view, visit http://gerrit.cloudera.org:8080/19097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dbde9095da78f6d1bd00adcc0a6e7dd63082bbc Gerrit-Change-Number: 19097 Gerrit-PatchSet: 19 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 12 Jan 2023 04:27:59 +0000 Gerrit-HasComments: Yes
