Yuqi Du has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19523 )

Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG@9
PS2, Line 9: This patch adds the flag 
"--master_support_auto_incrementing_column" to
           : guard the auto-incrementing column feature
> Yes initially that would have been better. As of know, the plan is to get t
Done


http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@121
PS2, Line 121: master_support_auto_incrementing_column
> Yes exactly! Thanks for pointing this out.
ok. no problem.



--
To view, visit http://gerrit.cloudera.org:8080/19523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Tue, 07 Mar 2023 03:21:06 +0000
Gerrit-HasComments: Yes

Reply via email to