Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19520/4/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/19520/4/src/kudu/fs/file_block_manager.cc@650 PS4, Line 650: if (!first_failure.ok()) { > It seems be better if adding total deleted block count we expected in the l Good suggestion, thanks! -- To view, visit http://gerrit.cloudera.org:8080/19520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6 Gerrit-Change-Number: 19520 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 24 Feb 2023 09:43:40 +0000 Gerrit-HasComments: Yes
