Hello Tidy Bot, Alexey Serbin, Yuqi Du, Ashwani Raina, Kudu Jenkins, KeDeng,
Wang Xixu,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19520
to look at the new patch set (#6).
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
---
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
M src/kudu/tablet/tablet_metadata.cc
6 files changed, 86 insertions(+), 80 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/19520/6
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>