Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/19520/5/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/19520/5/src/kudu/fs/log_block_manager.cc@2659 PS5, Line 2659: Status LogBlockManager::RemoveLogBlocks(const vector<BlockId>& block_ids, > warning: the parameter 'block_ids' is copied for each invocation but only u Done -- To view, visit http://gerrit.cloudera.org:8080/19520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6 Gerrit-Change-Number: 19520 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 24 Feb 2023 10:08:34 +0000 Gerrit-HasComments: Yes
