Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )
Change subject: KUDU-1945 Auto-incrementing column feature flag ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124 PS2, Line 124: TAG_FLAG(master_support_auto_incrementing_column, unsafe); > +1 Thanks for the notice. Yes, Attila explained this to me as well. Added the runtime tag. http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124 PS2, Line 124: TAG_FLAG(master_support_auto_incrementing_column, unsafe); > When upgrade a cluster to the new version which start to support "auto-incr Ah I see, thank you very much for the explanation! http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc@122 PS3, Line 122: cluster supports auto-incrementing columns. " > nit: is that really a type? Maybe, shorten to something like Done http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc@122 PS3, Line 122: "Whether the cluster supports auto-incrementing columns. " > nit: add a space after the period Done http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc@127 PS3, Line 127: > nit: leave one blank line is enough. Done -- To view, visit http://gerrit.cloudera.org:8080/19523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd Gerrit-Change-Number: 19523 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 09 Mar 2023 21:28:29 +0000 Gerrit-HasComments: Yes
