Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19523 )
Change subject: KUDU-1945 Auto-incrementing column feature flag ...................................................................... KUDU-1945 Auto-incrementing column feature flag This patch adds the flag "--master_support_auto_incrementing_column" to guard the auto-incrementing column feature. It prohibits users to create table with non-unique primary key. The default value for the flag is set to true in this patch. The verification happens on the RPC level. If the server has the feature turned off, or the server is older compared to the client - doesn't have the auto-incrementing feature -, the request gets rejected in both cases. Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd Reviewed-on: http://gerrit.cloudera.org:8080/19523 Tested-by: Kudu Jenkins Reviewed-by: Wenzhe Zhou <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/master/master.proto M src/kudu/master/master_service.cc 8 files changed, 64 insertions(+), 5 deletions(-) Approvals: Kudu Jenkins: Verified Wenzhe Zhou: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd Gerrit-Change-Number: 19523 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
