Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )
Change subject: KUDU-1945 Auto-incrementing column feature flag ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124 PS2, Line 124: TAG_FLAG(master_support_auto_incrementing_column, unsafe); > At this stage yes. When upgrade a cluster to the new version which start to support "auto-incrementing column", we can use rolling upgrade, maybe restart and upgrade Kudu master at first, then Kudu tservers. It may last a long time, say many hours. During this time, if a client send a request to master to create a table with auto-incrementing columns, the master will return success, but will fail (or some other kind of errors) if select a older tserver to create tablet replicas? In this case, we can set --master_support_auto_incrementing_column as false at the beginning, then set it by CLI tool at runtime without restart master after all tservers restarted. This is my understanding, although I'm not sure why the other --master_support_* flags are marked as runtime when first introduced. http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/19523/3/src/kudu/master/master_service.cc@127 PS3, Line 127: nit: leave one blank line is enough. -- To view, visit http://gerrit.cloudera.org:8080/19523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd Gerrit-Change-Number: 19523 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 07 Mar 2023 16:08:35 +0000 Gerrit-HasComments: Yes
