Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19633 )
Change subject: [Python] Refactor tests to use assertRaisesRegex ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/19633/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19633/3//COMMIT_MSG@7 PS3, Line 7: assertRaisesRegex > maybe mention that this method is coming from unittest.TestCase? Added more details. http://gerrit.cloudera.org:8080/#/c/19633/3/python/kudu/compat.py File python/kudu/compat.py: http://gerrit.cloudera.org:8080/#/c/19633/3/python/kudu/compat.py@76 PS3, Line 76: CompatUnitTest > nit: rename to CompatUnitTest Done http://gerrit.cloudera.org:8080/#/c/19633/3/python/kudu/compat.py@79 PS3, Line 79: expected_exception, expected_regex, *args, **kwa > nit: spaces after commas Done -- To view, visit http://gerrit.cloudera.org:8080/19633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41e2d69996ee0ed0f0418ae184d95239f2739efb Gerrit-Change-Number: 19633 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 21 Mar 2023 10:18:56 +0000 Gerrit-HasComments: Yes
