Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19633 )
Change subject: [Python] Refactor tests to use assertRaisesRegex ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19633/4/python/kudu/tests/test_schema.py File python/kudu/tests/test_schema.py: http://gerrit.cloudera.org:8080/#/c/19633/4/python/kudu/tests/test_schema.py@80 PS4, Line 80: not_found > nit: I think a space should be okay here, also capitalize the initial n to I'm not creating these error definitions, I'm only parsing them. These are raised from the underlying processes (which are in the C++ part of the codebase) In this case the only message I get is 'not_found', whereas in test_require_authn I get a much more detailed error for example: 'Not authorized: Could not connect to the cluster: Client connection negotiation failed: client connection to <host>:<port>: client requires authentication, but server does not have Kerberos enabled' In this case, I just choose a uniquely identifying substring, as the error_msg to parse against. -- To view, visit http://gerrit.cloudera.org:8080/19633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41e2d69996ee0ed0f0418ae184d95239f2739efb Gerrit-Change-Number: 19633 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 22 Mar 2023 08:42:54 +0000 Gerrit-HasComments: Yes
