Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19633 )
Change subject: [Python] Refactor tests to use assertRaisesRegex ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19633/4/python/kudu/tests/test_schema.py File python/kudu/tests/test_schema.py: http://gerrit.cloudera.org:8080/#/c/19633/4/python/kudu/tests/test_schema.py@80 PS4, Line 80: not_found nit: I think a space should be okay here, also capitalize the initial n to match the style of the other error messages http://gerrit.cloudera.org:8080/#/c/19633/4/python/kudu/tests/test_schema.py@119 PS4, Line 119: I some error messages start with capitalized first letters and some don't, either way is fine I guess, but make it consistent -- To view, visit http://gerrit.cloudera.org:8080/19633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41e2d69996ee0ed0f0418ae184d95239f2739efb Gerrit-Change-Number: 19633 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 21 Mar 2023 14:21:36 +0000 Gerrit-HasComments: Yes
