Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19633 )
Change subject: [Python] Refactor tests to use assertRaisesRegex ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/19633/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19633/6//COMMIT_MSG@18 PS6, Line 18: renamed to assertRaisesRegex : (without the trailing 'p') [2]. To be able to use assertRaisesRege > nit for here and above: I'm not sure I understand this notation -- what doe Done http://gerrit.cloudera.org:8080/#/c/19633/6//COMMIT_MSG@21 PS6, Line 21: . > nit: drop this part? Done http://gerrit.cloudera.org:8080/#/c/19633/6/python/kudu/compat.py File python/kudu/compat.py: http://gerrit.cloudera.org:8080/#/c/19633/6/python/kudu/compat.py@105 PS6, Line 105: yield : else: > What about Python 3.1? Does it work as expected in attempt to call unittes Good catch! The current if statement clearly distinguishes Python2 vs Python3. Created a new if/else branch for this CompatUnitTest class, which checks below 3.1 and else. -- To view, visit http://gerrit.cloudera.org:8080/19633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41e2d69996ee0ed0f0418ae184d95239f2739efb Gerrit-Change-Number: 19633 Gerrit-PatchSet: 8 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 05 Apr 2023 15:42:48 +0000 Gerrit-HasComments: Yes
