Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 )
Change subject: [KUDU-3452] Make validate table creating task not affected ...................................................................... Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc@5940 PS4, Line 5940: ERROR) << "Error selecting r > Thanks for your explain. TabletInfo is a CowObject. Function commit() will finally persist its state. If nothing has changed, function commit() maybe do nothing. http://gerrit.cloudera.org:8080/#/c/19594/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19594/6/src/kudu/master/catalog_manager.cc@5926 PS6, Line 5926: auto it = deferred.needs_create_rpc.begin() > nit: simplify by Done http://gerrit.cloudera.org:8080/#/c/19594/6/src/kudu/master/catalog_manager.cc@5934 PS6, Line 5934: et RPC finished. If a tablet selects re > nit: Also need to elaborate on why its state shouldn't be CREATING. Done http://gerrit.cloudera.org:8080/#/c/19594/6/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/19594/6/src/kudu/tools/kudu-admin-test.cc@1917 PS6, Line 1917: "--allow_unsafe_replication_factor=true", > nit: Could we also test this case by creating a table with only one replica Cloud you explain why we need test the case with one replica? 2-replica is also unsafe replication factor. http://gerrit.cloudera.org:8080/#/c/19594/6/src/kudu/tools/kudu-admin-test.cc@1962 PS6, Line 1962: > Is it necessary to create a table with range partitions? I guess it's not r You are right. I will remove it. http://gerrit.cloudera.org:8080/#/c/19594/6/src/kudu/tools/kudu-admin-test.cc@1978 PS6, Line 1978: > It would be great to check 2 of the 3 replicas have been created successful I guess you maybe mix this commit with commit: 19571: KUDU-3452 Create tablet without enough healthy tservers. http://gerrit.cloudera.org:8080/#/c/19594/6/src/kudu/tools/kudu-admin-test.cc@1982 PS6, Line 1982: { > Same. Done http://gerrit.cloudera.org:8080/#/c/19594/6/src/kudu/tools/kudu-admin-test.cc@1990 PS6, Line 1990: > Call WaitStarted() to ensure it has been started. WaitStarted() is not a member function of ExternalTabletServer. http://gerrit.cloudera.org:8080/#/c/19594/6/src/kudu/tools/kudu-admin-test.cc@1992 PS6, Line 1992: ring> master_f > How about cache the variable at first? Done -- To view, visit http://gerrit.cloudera.org:8080/19594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9 Gerrit-Change-Number: 19594 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 08 Apr 2023 14:10:14 +0000 Gerrit-HasComments: Yes
