Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19799 )
Change subject: [util] handle OpenSSL errors in JWT code ...................................................................... Patch Set 3: Code-Review+1 (2 comments) looks good to me, just two minor nits http://gerrit.cloudera.org:8080/#/c/19799/3/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/19799/3/src/kudu/util/jwt-util.cc@81 PS3, Line 81: using std::shared_ptr; nit: move this line in front of line 80 http://gerrit.cloudera.org:8080/#/c/19799/3/src/kudu/util/jwt-util.cc@412 PS3, Line 412: pub_key.clear(); nit: don't need -- To view, visit http://gerrit.cloudera.org:8080/19799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac5142c1dcaeec5042217e1c90f8e8770b36a670 Gerrit-Change-Number: 19799 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 21:09:30 +0000 Gerrit-HasComments: Yes
