Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19799 )
Change subject: [util] handle OpenSSL errors in JWT code ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19799/5/src/kudu/util/jwt-util-internal.h File src/kudu/util/jwt-util-internal.h: http://gerrit.cloudera.org:8080/#/c/19799/5/src/kudu/util/jwt-util-internal.h@222 PS5, Line 222: const std::string& base64_n, const std::string& base64_e, std::string& pub_key); > warning: non-const reference parameter 'pub_key', make it const or use a po I'm planning to take care of that in a separate changelist. http://gerrit.cloudera.org:8080/#/c/19799/5/src/kudu/util/jwt-util-internal.h@236 PS5, Line 236: std::string& pub_key); > warning: non-const reference parameter 'pub_key', make it const or use a po I'm planning to take care of that in a separate changelist. -- To view, visit http://gerrit.cloudera.org:8080/19799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac5142c1dcaeec5042217e1c90f8e8770b36a670 Gerrit-Change-Number: 19799 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 26 Apr 2023 22:04:26 +0000 Gerrit-HasComments: Yes
