Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19799 )
Change subject: [util] handle OpenSSL errors in JWT code ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/19799/5/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/19799/5/src/kudu/util/jwt-util.cc@564 PS5, Line 564: EC_KEY_new_by_curve_name nit: Does it makes sense to check the return value of this method as well? -- To view, visit http://gerrit.cloudera.org:8080/19799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac5142c1dcaeec5042217e1c90f8e8770b36a670 Gerrit-Change-Number: 19799 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 28 Apr 2023 21:16:07 +0000 Gerrit-HasComments: Yes
