Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19799 )
Change subject: [util] handle OpenSSL errors in JWT code ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/19799/3/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/19799/3/src/kudu/util/jwt-util.cc@81 PS3, Line 81: using std::string; > nit: move this line in front of line 80 Done http://gerrit.cloudera.org:8080/#/c/19799/3/src/kudu/util/jwt-util.cc@412 PS3, Line 412: string str_n; > nit: don't need Done http://gerrit.cloudera.org:8080/#/c/19799/4/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/19799/4/src/kudu/util/jwt-util.cc@446 PS4, Line 446: std::size(desc) - 1 > 'const constexpr size_t kKeyMaxSize = std::size(desc);' is ok? That's a good point: once there isn't trailing '\0' in the buffer, there is no need to dance around that. In addition, I realized this boilerplate code isn't needed since we have this functionality implemented properly in libsecurity. Thanks a lot for your input! -- To view, visit http://gerrit.cloudera.org:8080/19799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac5142c1dcaeec5042217e1c90f8e8770b36a670 Gerrit-Change-Number: 19799 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 26 Apr 2023 20:19:37 +0000 Gerrit-HasComments: Yes
