Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 15: (1 comment) > Patch Set 15: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9 PS12, Line 9: This tool is used to show the table name, table id and all : replicas on different tablet servers according to the tablet : id. > That means new fields are needed to be introduced, that is to say if you wa I think both solutions can unified as one. Using Yingchun's idea can solve this patch without upgrading kudu-masters, but it's not an optimal solution. Because it need 2 rpcs: one GetTabletLocations, the other ListTables(with list_tablets) and need keep the response and search ListTables's response the search tablet_id and table name and fill up CLI' information. Using this idea can be an optimal solution for this but need upgrading masters. Without upgrading masters, it works well too, and can't cause serious problems, but table id and table name is absent at CLI side, that's weakness when a new CLI tool requests to old masters. Both advantages is what we need. kudu would keep evolutions, a newer CLI on old master is not long-term status, same versions of kudu CLI and master is a long-term status, So I think, based this solution to be compatible with old masters, that is if table id and table name is absent, downgrade to ListTables to search and fill up the information. What do you think? And others? -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 15 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 28 Apr 2023 09:46:27 +0000 Gerrit-HasComments: Yes
