Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 18: (8 comments) http://gerrit.cloudera.org:8080/#/c/19501/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19501/18//COMMIT_MSG@17 PS18, Line 17: exmple example http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4152 PS18, Line 4152: // Stdout contains table name. If we check the how line match a partten, it's not necessary to check the table name separatly. http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4159 PS18, Line 4159: ASSERT_STR_CONTAINS(stdout, cluster_->tablet_server(i)->bound_rpc_hostport().host()); How ablout to check the whole line by using regex by ASSERT_STR_MATCHES? http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4177 PS18, Line 4177: ASSERT_TRUE(item["Table Name"].GetString()); Same, check it match some parttens. http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@104 PS18, Line 104: kudu:: nit: can be omitted. http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@415 PS18, Line 415: on the table which the tablet is a part of How about: of the table which the tablet blongs to http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@416 PS18, Line 416: tablet nit: the tablet http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@417 PS18, Line 417: .AddRequiredParameter({ kTabletIdArg, kTabletIdArgDesc }) How about to support query multiple tablets info? -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 18 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 09 Jun 2023 10:59:20 +0000 Gerrit-HasComments: Yes
