Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 18: (4 comments) > Patch Set 15: > > (1 comment) one http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9 PS12, Line 9: This tool is used to show the table name and all replicas on : different tablet servers according to the tablet id. : > I think both solutions can unified as one. Thanks every one. I decide to adopt the first advice. Get all tablets information and filter the one which matches the tablet id. http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.h@103 PS15, Line 103: internal::RemoteTabletServer** ts); > This change is not matter with this patch, so you can fix it at another pat Done http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.cc@293 PS15, Line 293: { > This change is not matter with this patch, so you can fix it at another pat Done http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/master/master.proto@459 PS15, Line 459: // DEPRECATED. Still set by servers, but should be igno > move this line to the end? and writing some comments is better. Done -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 18 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 04 Jun 2023 01:44:24 +0000 Gerrit-HasComments: Yes
