Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 19: (8 comments) http://gerrit.cloudera.org:8080/#/c/19501/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19501/18//COMMIT_MSG@17 PS18, Line 17: exampl > example Done http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4152 PS18, Line 4152: for (int i = 0; i < kNumTabletServers; i++) { > If we check the how line match a partten, it's not necessary to check the t Done http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4159 PS18, Line 4159: } > How ablout to check the whole line by using regex by ASSERT_STR_MATCHES? It is hard to use ASSERT_STR_MATCHES, because the output order of every hosts is different. But I will check every line. Please review the next commit. http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4177 PS18, Line 4177: // 1. Test the copy tool when the destination replica is healthy > Same, check it match some parttens. Done http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@104 PS18, Line 104: client > nit: can be omitted. Done http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@415 PS18, Line 415: of the table which the tablet blongs to " > How about: Done http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@416 PS18, Line 416: the ta > nit: Done http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@417 PS18, Line 417: .AddRequiredParameter({ kTabletIdArg, kTabletIdArgDesc }) > How about to support query multiple tablets info? Current solution will output empty if a tablet id is not existed. If this CLI supports query multiple tablet ids, it is difficult to make sure which one does not exist. If you want to query multiple tablets at the same time, maybe you can use shell to implement it. -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 19 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 16 Jun 2023 02:49:05 +0000 Gerrit-HasComments: Yes
