Yuqi Du has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19571 )

Change subject: KUDU-3452 Create tablet without enough healthy tservers
......................................................................


Patch Set 14:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/19571/14/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/19571/14/src/kudu/master/catalog_manager.cc@6677
PS14, Line 6677: (num_replicas + 1) / 2 > num_live_tservers
I think this equivalent condition may be better readability.

if (num_live_tservers < (num_replicas + 1) / 2)


http://gerrit.cloudera.org:8080/#/c/19571/14/src/kudu/master/catalog_manager.cc@6678
PS14, Line 6678: InvalidArgument
using IllegalState ?


http://gerrit.cloudera.org:8080/#/c/19571/14/src/kudu/master/catalog_manager.cc@6682
PS14, Line 6682: registered_ts_descs.size()
num_live_tservers



--
To view, visit http://gerrit.cloudera.org:8080/19571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6
Gerrit-Change-Number: 19571
Gerrit-PatchSet: 14
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Sat, 06 May 2023 04:04:02 +0000
Gerrit-HasComments: Yes

Reply via email to