Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Create tablet without enough healthy tservers ...................................................................... Patch Set 13: (2 comments) > Patch Set 12: > > (7 comments) http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9283 PS11, Line 9283: .Create(); > It will timeout. Because there are 5 tablet servers totally, and 3 tablet s IMO. only 2 tsevers available, your replication factor is 5. So this creating table should response fail to client rather than timeout. timeout means it maybe ok(available), in fact, it not available, this table neither write nor read. It's not reasonable, that means if all tservers are down, creating table request is also timeout. Before this patch, number of enough available tservers is >= n(replication factor) (this table is 5). This patch make this enough condition relaxed, downgrade from n to (n+1)/2 , this table is 3, very good. If this kudu cluster don't satisfy the condition, creating table request should fail. http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9396 PS11, Line 9396: _FATALS(c > There are 5 creating table commands, but only 4 commands will enter the sta IMO. The same above. This patch's benefits are that kudu can tolerate part of tablet server failures. If number of available tablet servers is not >= (replication_refactor + 1 ) / 2 , the creating table requests should fail. because this incomplete table can provide neither write nor read availability. -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 13 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 05 May 2023 09:50:37 +0000 Gerrit-HasComments: Yes
