Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Create tablet without enough healthy tservers ...................................................................... Patch Set 11: (15 comments) http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/master/catalog_manager.cc@418 PS10, Line 418: enough > Ah, sure, sorry my mistake. Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/master/catalog_manager.cc@5999 PS10, Line 5999: replic > What does "enough" mean, does 1 out of RF = 3 is enough? How about to descr Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/master/catalog_manager.cc@6008 PS10, Line 6008: " > Remove duplicate brackets. Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/master/catalog_manager.cc@6663 PS10, Line 6663: > nit: greater Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9196 PS10, Line 9196: const > nit: this could be constexpr as well Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9227 PS10, Line 9227: .set_range_partition_columns({ "foo" }) > nit: Check the type of Status fastly, i.e. : Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9234 PS10, Line 9234: ASSERT_TRUE(out.empty()); > Also check the table 'kOverRegistedTSTableName' is not existed in the clust Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9245 PS10, Line 9245: } > IIUC, ExternalDaemon::Shutdown() actually awaits for the process to be stop Yes, here waits until catalog manager (i.e. master) sees just 2 tablet servers alive instead of 5 actually used by GetDescriptorsAvailableForPlacement(). http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9247 PS10, Line 9247: > nit: not Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9264 PS10, Line 9264: } > nit: Check the type of Status fastly, i.e. : Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9267 PS10, Line 9267: > For a tablet with RF=5, for a positive scenario we are interested to see if Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9272 PS10, Line 9272: ->Type(client::KuduColumnSchema::INT32) > +1 Done http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9296 PS10, Line 9296: RT_EQ(5, do > Altering the replication factor is not a 'regular' sort of ALTER TABLE. Co Well, I have try to add a column, but it doesn't validate the number of replicas. Only altering the replication factor will validate the number of replicas. Please see Line 3629(function ValidateNumberReplicas()) in catalog_manager.cc. http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9299 PS10, Line 9299: i = > nit: will be OK, I will specify it. http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9325 PS10, Line 9325: rapidjson::D > nit: it's much cleaner to use variables local to the scope instead of relyi Done -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 11 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 26 Apr 2023 03:08:30 +0000 Gerrit-HasComments: Yes
