Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Create tablet without enough healthy tservers ...................................................................... Patch Set 12: (7 comments) http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/master/catalog_manager.cc@5999 PS11, Line 5999: select policy.ts_num() replicas > place the majority of replicas Done http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9189 PS11, Line 9189: INSTANTIATE_TEST_SUITE_P > nit: add an empty line Done http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9283 PS11, Line 9283: .Create(); > The status is deterministic, I think it should be not timeout. What do you It will timeout. Because there are 5 tablet servers totally, and 3 tablet servers is stopped. Creating a table with RF=5 will timeout, because (5+1)/2 > 2. There are not enough live tablet severs to place the replicas. http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9318 PS11, Line 9318: { > Why we need to start the second tablet server? Seems that three live tablet The case with 3 live tablet servers creating 5-replica tables has been tested, see line 9308. This case tests creating 5-replica tables with 4 live tablet servers. http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9362 PS11, Line 9362: // Add another column. Test alter table logic. > Maybe we should also test that if alter table operations(e.g. add a column, Done http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9387 PS11, Line 9387: > nit: All tables Done http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9396 PS11, Line 9396: _FATALS(c > I don't understand the number 4. There are 5 creating table commands, but only 4 commands will enter the stage of background creating tablets task. The first creating table with RF=6 will return directly, because its replication_factor > all register tablet severs, it will get a invalid argument error. -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 12 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 05 May 2023 06:43:53 +0000 Gerrit-HasComments: Yes
