Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 )
Change subject: [KUDU-3452] A tool to show on creating tables ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/19584/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19584/5//COMMIT_MSG@14 PS5, Line 14: Therefore it needs a tool to show the creating tables. Can we use the ksck tool to detect the creating tables? http://gerrit.cloudera.org:8080/#/c/19584/5//COMMIT_MSG@17 PS5, Line 17: list_creating_tables nit: Maybe change this to 'list_tables_with_creating_tablets'? http://gerrit.cloudera.org:8080/#/c/19584/5//COMMIT_MSG@24 PS5, Line 24: num_creating_tablets:1 state:RUNNING It seems that the state of a newly created table with some CREATING tablets is RUNNING, but the state of an existing table with some newly added CREATING tablets is ALTERING, right? http://gerrit.cloudera.org:8080/#/c/19584/5/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/19584/5/src/kudu/tools/tool_action_table.cc@238 PS5, Line 238: other flags is useless Why other flags can't work if listing_creating_tables is true? It seems to me that this flag is only used to filter out non-creating tables, the information of the listed tables shouldn't be affected. -- To view, visit http://gerrit.cloudera.org:8080/19584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5 Gerrit-Change-Number: 19584 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 06 Apr 2023 14:43:43 +0000 Gerrit-HasComments: Yes
