Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19584 )

Change subject: [KUDU-3452] A tool to show on creating tables
......................................................................


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/19584/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19584/5//COMMIT_MSG@14
PS5, Line 14: Therefore it needs a tool to show the creating tables.
> Can we use the ksck tool to detect the creating tables?
Ksck will not show the tables with creating tablets.


http://gerrit.cloudera.org:8080/#/c/19584/5//COMMIT_MSG@17
PS5, Line 17: list_tables_with_cre
> nit: Maybe change this to 'list_tables_with_creating_tablets'?
Done


http://gerrit.cloudera.org:8080/#/c/19584/5//COMMIT_MSG@24
PS5, Line 24: num_creating_tablets:1 state:RUNNING
> It seems that the state of a newly created table with some CREATING tablets
Yes. You also can say if creating a table, the state is RUNNING. If altering a 
table, the state is ALTERING.


http://gerrit.cloudera.org:8080/#/c/19584/5/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/19584/5/src/kudu/tools/tool_action_table.cc@238
PS5, Line 238: lets is set, other fla
> Why other flags can't work if listing_creating_tables is true? It seems to
When listing_creating_tables is true, it only shows the on-creating tables, it 
will not show the information of created tables.

If list_creating_tables and show_hash_partition_info are true, what it means? 
To show the on-creating tables and the partition information of created tables?



--
To view, visit http://gerrit.cloudera.org:8080/19584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5
Gerrit-Change-Number: 19584
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Mon, 17 Apr 2023 10:25:33 +0000
Gerrit-HasComments: Yes

Reply via email to