Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 )
Change subject: [KUDU-3452] A tool to report on table creation progress ...................................................................... Patch Set 16: (20 comments) http://gerrit.cloudera.org:8080/#/c/19584/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19584/15//COMMIT_MSG@10 PS15, Line 10: required number of replicas, the catalog manager retries creating : corresponding tablet replicas for a long time. : > If there isn't enough healthy tablet servers to create the required number Done http://gerrit.cloudera.org:8080/#/c/19584/15//COMMIT_MSG@14 PS15, Line 14: so users could be aware of its current status. If necessary, : they could make an informed decision to cancel > Hence there is a need to report on the table creation process, so users cou Done http://gerrit.cloudera.org:8080/#/c/19584/15//COMMIT_MSG@17 PS15, Line 17: > Maybe, name this new tool 'list_in_flight'? 'kudu table' already provides Good advice. Thanks. http://gerrit.cloudera.org:8080/#/c/19584/15//COMMIT_MSG@18 PS15, Line 18: ch adds a new comma > tables in the process of being created Done http://gerrit.cloudera.org:8080/#/c/19584/15//COMMIT_MSG@18 PS15, Line 18: : 'kudu table list_in_flight' : to show tables in the process of being created. For each in-flight : table, it repo > For each in-flight table, it reports on its id, name, state, and the number Done http://gerrit.cloudera.org:8080/#/c/19584/15//COMMIT_MSG@22 PS15, Line 22: > Below is an example of the new tool's output: Done http://gerrit.cloudera.org:8080/#/c/19584/15//COMMIT_MSG@24 PS15, Line 24: rsTable id:3c56ed6c1 > Shouldn't this be 'num_tablets_in_flight'? Done http://gerrit.cloudera.org:8080/#/c/19584/15//COMMIT_MSG@27 PS15, Line 27: nTable id:6c2209cc62 > ditto Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/master/catalog_manager.h@727 PS15, Line 727: List all the tables in the process of being creat > List all the tables in the process of being created or altered Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/master/catalog_manager.cc@3962 PS15, Line 3962: a tab > nit: a table Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/master/catalog_manager.cc@3963 PS15, Line 3963: the catalog man > nit: the catalog manager Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/master/catalog_manager.cc@3966 PS15, Line 3966: when the number > nit: in-flight tablets Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/master/catalog_manager.cc@3966 PS15, Line 3966: in the process of being > nit: in the process of being created or altered Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/master/master.proto@629 PS15, Line 629: on > nit: on Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/tools/kudu-tool-test.cc@9376 PS15, Line 9376: static string kTableListFormats[] = { : "pretty", "json", "json_compact", : } > Could this be replaced with something as simple as Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/tools/kudu-tool-test.cc@9383 PS15, Line 9383: TEST_P(ListInFlightTablesTest, TestListInFlightTables) { > Since this new test includes scenarios that times out, add SKIP_IF_SLOW_NOT Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/tools/kudu-tool-test.cc@9387 PS15, Line 9387: t char* con > nit: kNumReplicas (since kNumTabletServers) Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/tools/kudu-tool-test.cc@9390 PS15, Line 9390: constexpr int kNumTab > nit: move this comment to line 9395? Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/tools/kudu-tool-test.cc@9399 PS15, Line 9399: FATALS(StartMiniClus > nit: 'Get a Kudu client' or 'Create an instance of KuduClient' Done http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/tools/kudu-tool-test.cc@9420 PS15, Line 9420: .Create(); : }; : // Create a table and delete it to prove this CLI command will not list deleted tables. : { : > How is this relevant to the coverage that this test provides? It would be This case is necessary to prove that this CLI command will not list a deleted table. OK. I will add some comments. -- To view, visit http://gerrit.cloudera.org:8080/19584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5 Gerrit-Change-Number: 19584 Gerrit-PatchSet: 16 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 02 Jun 2023 04:13:44 +0000 Gerrit-HasComments: Yes
