Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 20: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/19501/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19501/20//COMMIT_MSG@22 PS20, Line 22: id | Table Name | Tablet Server UUID | Host | Port | Is Leader : -----+------------+-------+-------+-------+---- : abc | test_table | xxxxx | host1 | 43689 | V : abd | test_table | xxxx1 | host2 | 43035 | L : dbe | test_table | xxxx2 | host3 | 35209 | V nit: make the table columns are aligned. http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/kudu-tool-test.cc@4228 PS20, Line 4228: table_ids_str nit: tablet_ids_str ? http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/kudu-tool-test.cc@4252 PS20, Line 4252: "\"id\":\"$0\",\"Table Name\":\"$1\"," : "\"Tablet Server UUID\":\"$2\",\"Host\":\"$3\",\"Port\":\"$4\"" How about use "string literal" to improve readability? Refer to L1027 See more details: https://en.cppreference.com/w/cpp/language/string_literal http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/tool_action_tablet.cc@107 PS20, Line 107: id nit: Tablet ID ? -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 20 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 17 Jun 2023 16:51:51 +0000 Gerrit-HasComments: Yes
