Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/19949/10/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: http://gerrit.cloudera.org:8080/#/c/19949/10/java/kudu-client/src/main/java/org/apache/kudu/Schema.java@464 PS10, Line 464: equals > Howa about split this modification to another patch (of course add some tes Done http://gerrit.cloudera.org:8080/#/c/19949/10/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19949/10/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@416 PS10, Line 416: se { > It's a waste if the schema is 1, 2, 2, 2, 2, 2. The ops in schema 2 will no Done http://gerrit.cloudera.org:8080/#/c/19949/10/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: http://gerrit.cloudera.org:8080/#/c/19949/10/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java@141 PS10, Line 141: int rowCount = 0; > Add comments to explain why create a single bucket. Done http://gerrit.cloudera.org:8080/#/c/19949/10/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java@165 PS10, Line 165: row1.addInt("c1", 101); : session.apply(insert); : : Upsert upsert = table.newUpsert(); : PartialRow row2 = upsert.getRow(); : row2.addInt("c0", 102); : row2.addInt("c1", 102); : session.apply(upsert); : session.flush(); : > Wrap a function? you can reuse it below. Done -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 11 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 18 Jun 2023 11:08:20 +0000 Gerrit-HasComments: Yes
