Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/19949/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19949/7//COMMIT_MSG@20 PS7, Line 20: This patch will validate the schema of multiple rows which belong : to the same tablet. If the schema is different, it puts them into : the different groups as different batches. Another idea is to trigger a flush() in apply(op) when found op's schema is different (add/drop columns) with the buffered ops' schema in AUTO_FLUSH_BACKGROUND mode. In this way, the logic in TabletLookupCB can be kept as before. -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 14 Jun 2023 16:17:47 +0000 Gerrit-HasComments: Yes
