Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/19949/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19949/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@346 PS7, Line 346: batches by tablet nit: The comments have to be updated. http://gerrit.cloudera.org:8080/#/c/19949/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@423 PS7, Line 423: batches.size() + 1 Should be: batches.size() + extraBatches.size() + 1 ? http://gerrit.cloudera.org:8080/#/c/19949/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: http://gerrit.cloudera.org:8080/#/c/19949/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java@139 PS7, Line 139: AUTO_FLUSH_BACKGROUND I see you flush manually below, why set the mode as AUTO_FLUSH_BACKGROUND here? http://gerrit.cloudera.org:8080/#/c/19949/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java@151 PS7, Line 151: row2.addInt("c0", 101); : row2.addInt("c1", 101); : Is it too special that upsert on the same row? It's enough to cover the case you fix to make sure they are on the same tablet, right? (You can create a table with a single partiton to make sure the 2 rows are on the same tablet) http://gerrit.cloudera.org:8080/#/c/19949/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java@190 PS7, Line 190: Also check we can read the rows correctly. -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 14 Jun 2023 15:36:11 +0000 Gerrit-HasComments: Yes
