Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19949/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19949/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@372 PS7, Line 372: extraBatches is used to store operations when found table has changed : // compared with previous rows. How about: 'extraBatches' is used to store batches of operations which have different schemas to the previous ones. http://gerrit.cloudera.org:8080/#/c/19949/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@415 PS7, Line 415: batch nit: !batch -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 14 Jun 2023 15:09:02 +0000 Gerrit-HasComments: Yes
