Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20205 )
Change subject: Fix flaky TestDownloadSuperblockInBatch ...................................................................... Patch Set 2: (1 comment) Thank you for the fix! http://gerrit.cloudera.org:8080/#/c/20205/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/20205/2/src/kudu/tools/kudu-tool-test.cc@9442 PS2, Line 9442: src_tserver->WaitStarted() Should this be wrapped into ASSERT_OK() as well? -- To view, visit http://gerrit.cloudera.org:8080/20205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id65cf0586416f70c72f61b2e6886bfc5d0690c0f Gerrit-Change-Number: 20205 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Tue, 18 Jul 2023 01:15:49 +0000 Gerrit-HasComments: Yes