Marton Greber has posted comments on this change. (
http://gerrit.cloudera.org:8080/20205 )
Change subject: Fix flaky TestDownloadSuperblockInBatch
......................................................................
Patch Set 3:
> Patch Set 3:
>
> (1 comment)
And if I include the ScopedRegisterSink inside the new scope, it won't even
build.
Like this:
// Copy tablet replicas from source tserver to destination tserver.
StringVectorSink capture_logs;
{
ScopedRegisterSink rs(&capture_logs);
string stderr;
RunActionStderrString(
...
}
--
To view, visit http://gerrit.cloudera.org:8080/20205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id65cf0586416f70c72f61b2e6886bfc5d0690c0f
Gerrit-Change-Number: 20205
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Tue, 18 Jul 2023 20:36:47 +0000
Gerrit-HasComments: No
