Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20205 )
Change subject: Fix flaky TestDownloadSuperblockInBatch ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20205/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/20205/3/src/kudu/tools/kudu-tool-test.cc@9451 PS3, Line 9451: RegisterSink rs(&capture_logs); : rs.Register(); > Instead of this, you could add an extra scope around RunActionStderrString. I added a scope for RunActionStderrString, but still got the tsan report. Just to double check that this is what you meant. Please find here the: git diff, test cmd, and tsan output: https://github.com/martongreber/20205/blob/main/details -- To view, visit http://gerrit.cloudera.org:8080/20205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id65cf0586416f70c72f61b2e6886bfc5d0690c0f Gerrit-Change-Number: 20205 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 18 Jul 2023 18:19:11 +0000 Gerrit-HasComments: Yes
