Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20205
to look at the new patch set (#3).
Change subject: Fix flaky TestDownloadSuperblockInBatch
......................................................................
Fix flaky TestDownloadSuperblockInBatch
The test has been failing from time to time with the following message:
Expected: has substring "recv error: Network error: RPC frame had a
length" Actual: "... UNKNOWN_ERROR: received error code Illegal state:
The tablet is not in a running state: BOOTSTRAPPING from remote service"
The fix is to add a wait in the test after the restart.
Previous to this patch, this fluke made the kudu-tool-test quite flaky:
http://dist-test.cloudera.org/job?job_id=root.1689595728.503176
* 125/400 failed
With this patch:
http://dist-test.cloudera.org/job?job_id=root.1689597615.525960
* 6/400 failed
^ I verified that those 6 are unrelated failures, compared to what is
beeing fixed in this patch.
(The command which has been used to produce the above dist-test results:
KUDU_ALLOW_SLOW_TESTS=1 ../../build-support/dist_test.py loop -n 100 \
-- ./bin/kudu-tool-test --stress_cpu_threads=16)
Moreover, TSAN reported a race condition on 'StringVectorSink
capture_logs'. I created a new 'RegisterSink' class based on the
existing 'ScopedRegisterSink' class. The former one has functions to
register/unregister the sink. In TestDownloadSuperblockInBatch I used
this class to unregister the sink after we are done executing the tool
command. This way the sanitizer wasn't complaining about a race
condition on 'capture_logs'.
Since Kudu master branch is now blocked by this issue, I did not create
separate patches for 'RegisterSink' and the test fix, to be able to move
faster.
Change-Id: Id65cf0586416f70c72f61b2e6886bfc5d0690c0f
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/logging-test.cc
M src/kudu/util/logging_test_util.h
3 files changed, 59 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/20205/3
--
To view, visit http://gerrit.cloudera.org:8080/20205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id65cf0586416f70c72f61b2e6886bfc5d0690c0f
Gerrit-Change-Number: 20205
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <greber...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com>
