Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20205 )
Change subject: Fix flaky TestDownloadSuperblockInBatch ...................................................................... Fix flaky TestDownloadSuperblockInBatch The test has been failing from time to time with the following message: Expected: has substring "recv error: Network error: RPC frame had a length" Actual: "... UNKNOWN_ERROR: received error code Illegal state: The tablet is not in a running state: BOOTSTRAPPING from remote service" The fix is to add a wait in the test after the restart. Previous to this patch, this fluke made the kudu-tool-test quite flaky: http://dist-test.cloudera.org/job?job_id=root.1689595728.503176 * 125/400 failed With this patch: http://dist-test.cloudera.org/job?job_id=root.1689597615.525960 * 6/400 failed ^ I verified that those 6 are unrelated failures, compared to what is beeing fixed in this patch. (The command which has been used to produce the above dist-test results: KUDU_ALLOW_SLOW_TESTS=1 ../../build-support/dist_test.py loop -n 100 \ -- ./bin/kudu-tool-test --stress_cpu_threads=16) Moreover, TSAN reported a race condition on 'StringVectorSink capture_logs'. Moved ScopedRegisterSink and the tool command into a scope, such that it works as expected. Change-Id: Id65cf0586416f70c72f61b2e6886bfc5d0690c0f Reviewed-on: http://gerrit.cloudera.org:8080/20205 Tested-by: Kudu Jenkins Reviewed-by: Mahesh Reddy <mre...@cloudera.com> Reviewed-by: Alexey Serbin <ale...@apache.org> --- M src/kudu/tools/kudu-tool-test.cc 1 file changed, 28 insertions(+), 25 deletions(-) Approvals: Kudu Jenkins: Verified Mahesh Reddy: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id65cf0586416f70c72f61b2e6886bfc5d0690c0f Gerrit-Change-Number: 20205 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>
